feat: Add a projects watcher #26

Merged
xbazzi merged 4 commits from feat/projects-dir-watcher into next 2026-07-03 02:40:44 +00:00
Collaborator

closes #8
closes #25 by proxy

closes #8 closes #25 by proxy
xbazzi requested review from javif89 2026-07-03 02:16:47 +00:00
xbazzi self-assigned this 2026-07-03 02:16:49 +00:00
xbazzi added this to the v1.1.0 milestone 2026-07-03 02:16:57 +00:00
javif89 requested changes 2026-07-03 02:18:42 +00:00
Dismissed
javif89 left a comment

Please use conventional commit style for PR titles

Please use conventional commit style for PR titles
javif89 requested changes 2026-07-03 02:23:15 +00:00
Dismissed
@ -139,0 +175,4 @@
async fn scan_and_update_projects(&self) -> Result<(), DataError> {
info!("Projects directory changed; rescanning projects entries");
let scanner = Arc::clone(&self.app_scanner);
Owner

This is currently using the app scanner, meaning it's not doing what's intended (scan projects)

This is currently using the app scanner, meaning it's not doing what's intended (scan projects)
javif89 marked this conversation as resolved
@ -139,0 +182,4 @@
self.db
.items()
.insert_of_kind(app_entries, crate::core::ItemKind::DesktopEntry)
Owner

Once the above is fixed. This also needs to be updated to insert the correct ItemKind

Once the above is fixed. This also needs to be updated to insert the correct `ItemKind`
javif89 marked this conversation as resolved
@ -20,3 +22,3 @@
let notify_config = Config::default();
let mut debouncer = new_debouncer_opt::<_, RecommendedWatcher, RecommendedCache>(
Duration::from_secs(2),
Duration::from_millis(DEBOUNCER_TIMEOUT_MS),
Owner

Nice!

Nice!
javif89 marked this conversation as resolved
@ -63,3 +66,3 @@
impl WaycastDaemon {
pub fn run(&self) {
let (app_event_tx, mut app_event_rx) = mpsc::channel(1);
let (app_event_tx, mut app_event_rx) = mpsc::channel(MAX_MPSC_BUF_SIZE);
Owner

Love that you're reducing the usage of magic numbers. Good job! 🥳

Love that you're reducing the usage of magic numbers. Good job! 🥳
xbazzi marked this conversation as resolved
xbazzi requested review from javif89 2026-07-03 02:34:47 +00:00
javif89 approved these changes 2026-07-03 02:36:56 +00:00
javif89 left a comment

LGMT. Good job 🥳 📦 🚀

LGMT. Good job 🥳 📦 🚀
xbazzi force-pushed feat/projects-dir-watcher from 7baf9d09cc to 75e90b62b9 2026-07-03 02:37:55 +00:00 Compare
xbazzi changed title from Add a projects watcher to feat: Add a projects watcher 2026-07-03 02:39:24 +00:00
xbazzi merged commit 963c68ffd9 into next 2026-07-03 02:40:44 +00:00
xbazzi referenced this pull request from a commit 2026-07-03 02:40:45 +00:00
xbazzi deleted branch feat/projects-dir-watcher 2026-07-03 02:40:46 +00:00
Sign in to join this conversation.
No description provided.