waycasthq/waycast
waycasthq/waycast
Watch
2
0
Fork
You've already forked waycast
 0
Code Issues 14 Pull requests Projects 2 Releases 3 Packages Wiki Activity Actions

refactor: Centralize most icon resolution logic into IconResolver #57

Merged
javif89 merged 9 commits from refactor/icon-resolution into master 2026-08-07 18:58:17 -04:00
Conversation 0 Commits 9 Files changed 12 +153 -128
javif89 commented 2026-08-07 17:47:24 -04:00
Owner
Copy link

Why

Previously, icon resolution and fallback handling happened in:

  • 2 methods of the UI
  • Daemon code

This made it hard to follow icon resolution logic as well as handling fallbacks consistently. This PR doesn't consolidate all usages, but it's a good start and takes care of most of the host paths.

Closes #11
Fixes #53

## Why Previously, icon resolution and fallback handling happened in: - 2 methods of the UI - Daemon code This made it hard to follow icon resolution logic as well as handling fallbacks consistently. This PR doesn't consolidate _all_ usages, but it's a good start and takes care of most of the host paths. Closes #11 Fixes #53
chore: Final consolidation pass
Some checks failed
Changelog / require-fragment (pull_request) Failing after 5s
Details
CI / test (pull_request) Failing after 53s
Details
CI / clippy (pull_request) Failing after 56s
Details
081015d1d5
chore: Add changelog fragments
Some checks failed
Changelog / require-fragment (pull_request) Successful in 8s
Details
CI / test (pull_request) Has been cancelled
Details
CI / clippy (pull_request) Has been cancelled
Details
a3e400df45
chore: lint
Some checks failed
Changelog / require-fragment (pull_request) Successful in 7s
Details
CI / clippy (pull_request) Failing after 55s
Details
CI / test (pull_request) Failing after 1m4s
Details
99bbf6013d
chore: Remove already addressed todo
Some checks failed
Changelog / require-fragment (pull_request) Successful in 8s
Details
CI / test (pull_request) Failing after 57s
Details
CI / clippy (pull_request) Failing after 59s
Details
d9a32b3afc
chore: Bump rust version in ci workflows
Some checks failed
Changelog / require-fragment (pull_request) Successful in 10s
Details
CI / clippy (pull_request) Failing after 1m0s
Details
CI / test (pull_request) Has been cancelled
Details
a8661882a4
chore: Bump rust version I missed
Some checks failed
Changelog / require-fragment (pull_request) Successful in 6s
Details
CI / test (pull_request) Failing after 5m32s
Details
CI / clippy (pull_request) Successful in 6m33s
Details
58114154c0
chore: Remove test until I figure out how to make it pass in CI
All checks were successful
Changelog / require-fragment (pull_request) Successful in 4s
Details
CI / clippy (pull_request) Successful in 1m23s
Details
CI / test (pull_request) Successful in 5m19s
Details
9be5d23089
javif89 merged commit 00200e842b into master 2026-08-07 18:58:17 -04:00
javif89 deleted branch refactor/icon-resolution 2026-08-07 18:58:18 -04:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
CI/CD

   
Code Cleanup
Anything related to making waycast code more readable and extensible

  
DX
Developer Experience

  
UI

   
UX
User Experience

  
bug
Something is not working

  
chore

   
duplicate
This issue or pull request already exists

  
enhancement
New feature

  
help wanted
Need some help

  
invalid
Something is wrong

  
packaging
Related to packaging waycast. Either nix or other forms

  
question
More information is needed

  
wontfix
This won't be fixed

No labels
CI/CD
Code Cleanup
DX
UI
UX
bug
chore
duplicate
enhancement
help wanted
invalid
packaging
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
waycasthq/waycast!57
No description provided.